Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 26, 2025

What do these changes do?

This PR improves the UX of the "Starting osparc" message.

  • We now say first "Starting osparc" while the resources that need to be fetched before the dashboard resources are fetched.
  • Then each tab will say "Loading its {$resource}".
  • If there are no {$resources} found a message will be displayed.
  • The loading page is now removed when the cards are renderer (avoiding the potential empty list that was shown while the backend resources were renderer as cards).

LoadingPages

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Jun 26, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 26, 2025
@odeimaiz odeimaiz added this to the Engage milestone Jun 26, 2025
@odeimaiz odeimaiz marked this pull request as ready for review June 26, 2025 13:03
@odeimaiz odeimaiz requested a review from Copilot June 26, 2025 13:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the dashboard UX by showing per-tab loading messages, deferring hiding until all resources load, and introducing a context‐aware “No resources found” label.

  • Show a custom “Loading …” page in each browser before fetching resources and hide it in promise .finally().
  • Add a noResourcesFound label to ResourceContainerManager with context‐specific messages.
  • Invoke evaluateNoResourcesFoundLabel in Tutorial, Study, and App browsers to display when no items exist.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TutorialBrowser.js Show “Loading Tutorials…” and hide loading page in .finally().
StudyBrowser.js Show “Loading Projects…” and coordinate hide via Promise.all().
AppBrowser.js Show “Loading Apps…” and hide loading page after services/hypertools load.
ResourceContainerManager.js Add noResourcesFound label and evaluateNoResourcesFoundLabel() method.
Dashboard.js Minor formatting: add missing semicolon after initResources() call.

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 26, 2025
@odeimaiz
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b4006b9

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

@mergify mergify bot merged commit b4006b9 into ITISFoundation:master Jun 26, 2025
59 of 60 checks passed
@odeimaiz odeimaiz deleted the enh/starting-ux branch June 26, 2025 14:25
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants